From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <xdje42@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>, Hui Zhu <hui_zhu@mentor.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: target-delegates.c needs some TLC [was Re: [OB PATCH] target.h (to_traceframe_info): Fix TARGET_DEFAULT_RETURN]
Date: Mon, 10 Mar 2014 02:47:00 -0000 [thread overview]
Message-ID: <531D2739.3000508@codesourcery.com> (raw)
In-Reply-To: <CAP9bCMTwuW_2_3Dn+JynOxtgyv862ghs8GZgOyUm8MbEcfb=Tw@mail.gmail.com>
On 03/06/2014 01:20 PM, Doug Evans wrote:
> While I realize we don't want to require perl for building gdb (and I
> for one would never advocate it), I wonder if we can do at least a bit
> better.
perl is required by git, and GDB source is version controlled by git.
I assume that most of the host machine used for gdb development have
git and perl installed. People may get source from release, and
generate patch on top of it (without git/perl installed). It isn't
common, is it?
Anyway, we can check whether perl is installed. If perl is installed,
run make-target-delegates during make and error out if new-generated
target-delegates.c is different from the one in gdb source. Is it good?
If yes, I'll submit a patch for this.
Using --enable-maintainer-mode or adding new --enable-foo option isn't
appealing to me.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-03-10 2:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 5:20 Doug Evans
2014-03-07 18:33 ` Pedro Alves
2014-03-09 23:16 ` Doug Evans
2014-03-21 16:25 ` Pedro Alves
2014-03-10 2:47 ` Yao Qi [this message]
2014-03-10 2:54 ` Hui Zhu
2014-03-10 5:34 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531D2739.3000508@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
--cc=tromey@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox