From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30949 invoked by alias); 10 Mar 2014 02:47:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30932 invoked by uid 89); 10 Mar 2014 02:47:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Mar 2014 02:47:36 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WMqFZ-0003HC-Aj from Yao_Qi@mentor.com ; Sun, 09 Mar 2014 19:47:33 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 9 Mar 2014 19:47:33 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Sun, 9 Mar 2014 19:47:32 -0700 Message-ID: <531D2739.3000508@codesourcery.com> Date: Mon, 10 Mar 2014 02:47:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Doug Evans CC: Tom Tromey , Hui Zhu , gdb-patches ml Subject: Re: target-delegates.c needs some TLC [was Re: [OB PATCH] target.h (to_traceframe_info): Fix TARGET_DEFAULT_RETURN] References: In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00224.txt.bz2 On 03/06/2014 01:20 PM, Doug Evans wrote: > While I realize we don't want to require perl for building gdb (and I > for one would never advocate it), I wonder if we can do at least a bit > better. perl is required by git, and GDB source is version controlled by git. I assume that most of the host machine used for gdb development have git and perl installed. People may get source from release, and generate patch on top of it (without git/perl installed). It isn't common, is it? Anyway, we can check whether perl is installed. If perl is installed, run make-target-delegates during make and error out if new-generated target-delegates.c is different from the one in gdb source. Is it good? If yes, I'll submit a patch for this. Using --enable-maintainer-mode or adding new --enable-foo option isn't appealing to me. -- Yao (齐尧)