From: Phil Muldoon <pmuldoon@redhat.com>
To: Maxim Bublis <satori@yandex-team.ru>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] gdb/python: raise TypeError instead of abort() on calling .value() method for label symbol object
Date: Tue, 04 Mar 2014 17:57:00 -0000 [thread overview]
Message-ID: <53161401.5080408@redhat.com> (raw)
In-Reply-To: <1393929360-31299-3-git-send-email-satori@yandex-team.ru>
On 04/03/14 10:35, Maxim Bublis wrote:
>
> + if (SYMBOL_CLASS (symbol) == LOC_LABEL)
> + {
> + PyErr_SetString (PyExc_TypeError, "cannot get the value of a label");
Error text should be complete sentences with punctuation and proper
capitalization (I know there are a few in the code base that aren't,
but we'll get them all eventually).
> + return NULL;
> + }
> +
> TRY_CATCH (except, RETURN_MASK_ALL)
> {
> if (frame_obj != NULL)
This patch looks fine to me apart from one further small aside (please
wait for a maintainer to approve your patch, regardless). In the
documentation you note there are other types of symbol that can
produce this error: e.g., SYMBOL_LOC_TYPEDEF. Can you please audit and
include checks for all, while you are there? I noticed only the
explicit LOC_LABEL check in the patch above.
Cheers,
Phil
next prev parent reply other threads:[~2014-03-04 17:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 10:36 [PATCH 0/3] Fixed abortion using Python API " Maxim Bublis
2014-03-04 10:37 ` [PATCH 2/3] gdb/python: raise TypeError instead of abort() on calling .value() method " Maxim Bublis
2014-03-04 17:57 ` Phil Muldoon [this message]
[not found] ` <07E7B14B-748D-4CF7-A8AD-623AF5D6E701@yandex-team.ru>
2014-03-06 8:37 ` Phil Muldoon
2014-03-04 10:37 ` [PATCH 1/3] gdb/testsuite/gdb.python: Added testcase for .value() method Maxim Bublis
2014-03-05 13:41 ` [PATCH v2 1/3] gdb/testsuite/gdb.python: Added testcase for value method Maxim Bublis
[not found] ` <1394026864-4691-2-git-send-email-satori@yandex-team.ru>
2014-04-14 7:41 ` [PATCH v2 2/3] gdb/python: raise TypeError instead of abort on calling value method for label symbol object Phil Muldoon
2014-04-16 17:20 ` Maxim Bublis
2014-04-17 12:44 ` Maxim Bublis
2014-03-04 10:37 ` [PATCH 3/3] gdb/doc/python.texi: documented gdb.SYMBOL_LOC_LABEL. Added notion on possible exception thrown from symbol object .value() method Maxim Bublis
2014-03-04 16:53 ` Eli Zaretskii
2014-03-05 13:34 ` Maxim Bublis
2014-03-05 13:41 ` [PATCH v2 3/3] gdb/doc/python.texi: documented gdb.SYMBOL_LOC_LABEL, added notion on possible exceptions thrown from symbol object value method Maxim Bublis
2014-03-05 17:12 ` Eli Zaretskii
2014-03-25 16:51 ` [PATCH 0/3] Fixed abortion using Python API for label symbol object Maxim Bublis
2014-03-25 19:51 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53161401.5080408@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=satori@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox