Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <lgustavo@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: Hui Zhu <teawater@gmail.com>,
	 gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR 12702 - gdb can hang waiting for thread group leader (gdbserver)
Date: Thu, 27 Feb 2014 14:54:00 -0000	[thread overview]
Message-ID: <530F517C.5000802@codesourcery.com> (raw)
In-Reply-To: <530F4DDB.3010803@redhat.com>

On 02/27/2014 11:38 AM, Pedro Alves wrote:
> On 01/23/2014 02:00 PM, Pedro Alves wrote:
>> This is main gripe with this patch.  I'd really like to avoid
>> bringing in more of this broken use of waitpid(PID) into gdbserver
>> (I realize most of this is copied from GDB), and this duplication
>> of low level wait status handling.  I think we can do
>> better in gdbserver.  There's really no need for wait_for_sigstop
>> to wait for each LWP in turn.   I think that with some
>> refactoring, we can make it reuse linux_wait_for_event, and
>> only end up with having to handle pending statuses in one place.
>>
>> So I've been working on this most of this week, and I got this
>> almost done but I'm afraid I'll need to give attention to other
>> work, so I'm not sure I'll be able to be back at this before
>> February.  Anyway, I'll post a WIP series in response to this email.
>
> I've now rebased this on current mainline, wrote ChangeLogs, etc.
> and pushed it.
>
> https://sourceware.org/ml/gdb-patches/2014-02/msg00826.html
>
>> In addition, it goes a step forward and starts adding support for
>> TARGET_WAITKIND_NO_RESUMED to the RSP as well, which is needed for
>> fully fixing no-unwaited-for-left.exp.
>
> I didn't get to finish that one yet, so I've left it out for now.
>

Thanks Pedro. That is a nice fix to have.

Luis


      reply	other threads:[~2014-02-27 14:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-20 10:00 Hui Zhu
2013-07-24 18:25 ` Pedro Alves
2013-11-19  6:19   ` Hui Zhu
2014-01-23 14:51     ` Pedro Alves
2014-01-23 14:10       ` [PATCH 1/5] Move ptid_match to common/ptid.c Pedro Alves
2014-01-23 14:10         ` [PATCH 2/5] Move status_to_str to nat/linux-waitpid.c Pedro Alves
2014-01-23 14:10         ` [PATCH 4/5] Teach gdbserver's linux backend about no unwaited-for children (TARGET_WAITDKIND_NO_RESUMED) Pedro Alves
2014-01-23 14:10         ` [PATCH 5/5] Add TARGET_WAITKIND_NO_RESUMED support to the RSP Pedro Alves
2014-01-23 14:10         ` [PATCH 3/5] Linux waitpid/__WALL emulation wrapper: If WNOHANG is set, don't touch sigprocmask Pedro Alves
2014-02-27 14:47           ` Pedro Alves
2014-02-27 14:38       ` [PATCH] Fix PR 12702 - gdb can hang waiting for thread group leader (gdbserver) Pedro Alves
2014-02-27 14:54         ` Luis Machado [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530F517C.5000802@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox