From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29245 invoked by alias); 27 Feb 2014 14:54:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29233 invoked by uid 89); 27 Feb 2014 14:54:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Feb 2014 14:54:06 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WJ2La-0002tq-HM from Luis_Gustavo@mentor.com ; Thu, 27 Feb 2014 06:54:02 -0800 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 27 Feb 2014 06:54:02 -0800 Received: from [172.30.12.174] ([172.30.12.174]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 27 Feb 2014 06:54:02 -0800 Message-ID: <530F517C.5000802@codesourcery.com> Date: Thu, 27 Feb 2014 14:54:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Pedro Alves CC: Hui Zhu , gdb-patches ml Subject: Re: [PATCH] Fix PR 12702 - gdb can hang waiting for thread group leader (gdbserver) References: <51F01C13.3080402@redhat.com> <52E12075.3040601@redhat.com> <530F4DDB.3010803@redhat.com> In-Reply-To: <530F4DDB.3010803@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00832.txt.bz2 On 02/27/2014 11:38 AM, Pedro Alves wrote: > On 01/23/2014 02:00 PM, Pedro Alves wrote: >> This is main gripe with this patch. I'd really like to avoid >> bringing in more of this broken use of waitpid(PID) into gdbserver >> (I realize most of this is copied from GDB), and this duplication >> of low level wait status handling. I think we can do >> better in gdbserver. There's really no need for wait_for_sigstop >> to wait for each LWP in turn. I think that with some >> refactoring, we can make it reuse linux_wait_for_event, and >> only end up with having to handle pending statuses in one place. >> >> So I've been working on this most of this week, and I got this >> almost done but I'm afraid I'll need to give attention to other >> work, so I'm not sure I'll be able to be back at this before >> February. Anyway, I'll post a WIP series in response to this email. > > I've now rebased this on current mainline, wrote ChangeLogs, etc. > and pushed it. > > https://sourceware.org/ml/gdb-patches/2014-02/msg00826.html > >> In addition, it goes a step forward and starts adding support for >> TARGET_WAITKIND_NO_RESUMED to the RSP as well, which is needed for >> fully fixing no-unwaited-for-left.exp. > > I didn't get to finish that one yet, so I've left it out for now. > Thanks Pedro. That is a nice fix to have. Luis