From: Pedro Alves <palves@redhat.com>
To: Tom de Vries <tdevries@suse.de>,
Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH][gdb] Only force INTERP_CONSOLE ui_out for breakpoint commands in MI mode
Date: Thu, 03 Oct 2019 14:02:00 -0000 [thread overview]
Message-ID: <52ad768c-5e84-f543-f544-be074364979b@redhat.com> (raw)
In-Reply-To: <03ba9add-28c6-ab08-1d96-920d8a57bf67@suse.de>
On 10/3/19 2:51 PM, Tom de Vries wrote:
> On 03-10-19 14:10, Pedro Alves wrote:
>>> --- a/gdb/cli/cli-script.c
>>> +++ b/gdb/cli/cli-script.c
>>> @@ -697,6 +697,9 @@ execute_control_command_1 (struct command_line *cmd, int from_tty)
>>> enum command_control_type
>>> execute_control_command (struct command_line *cmd, int from_tty)
>>> {
>>> + if (!current_interp_named_p (INTERP_MI))
>>> + return execute_control_command_1 (cmd, from_tty);
>>
>> Wouldn't we need to handle INTERP_MI1/INTERP_MI2/INTERP_MI3 as well?
>>
>> Would
>>
>> if (current_uiout->is_mi_like_p ())
>>
>> instead work?
>
> Yep, that works as well. Patch updated accordingly and re-tested.
>
> OK for trunk?
Seems good to me, but I think we should hear from Andrew as well.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-10-03 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 9:58 [PATCH][gdb] Make INTERP_TUI's default ui_out the INTERP_CONSOLE ui_out Tom de Vries
2019-09-05 12:50 ` Tom de Vries
2019-09-24 15:24 ` [PING][PATCH][gdb] " Tom de Vries
2019-09-24 17:31 ` [PATCH][gdb] " Andrew Burgess
2019-09-24 23:20 ` Tom de Vries
2019-09-25 8:36 ` Andrew Burgess
2019-10-01 12:59 ` Tom de Vries
2019-10-03 10:01 ` [PATCH][gdb] Only force INTERP_CONSOLE ui_out for breakpoint commands in MI mode Tom de Vries
2019-10-03 12:11 ` Pedro Alves
2019-10-03 13:51 ` Tom de Vries
2019-10-03 14:02 ` Pedro Alves [this message]
2019-11-11 16:27 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ad768c-5e84-f543-f544-be074364979b@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox