From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60229 invoked by alias); 3 Oct 2019 14:02:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60221 invoked by uid 89); 3 Oct 2019 14:02:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2019 14:02:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570111375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KmBxOfQm1YojrJ+Hl6G4nA92/GmUx/zg9x4ddvaxCJk=; b=eFgR3Tgj96rcheoZxAfYboqj/rwBf2IUCP/lPJc32No1pBfCC7/OfGe3Z1XiOWTUFLDI/K XqZq37qjntSMK6ryBZLS0mt8KCMRvm54CQobGgPVu4s6yIl6OGa9JEiarg/QuaLrlnIBje A8bPMeINXtDpHzCzBcmnQbuF/r2GXpw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-Jn-SQZIKMTmJclbwpmIYdg-1; Thu, 03 Oct 2019 10:02:52 -0400 Received: by mail-wm1-f70.google.com with SMTP id l3so1168204wmf.8 for ; Thu, 03 Oct 2019 07:02:52 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id 90sm4079555wrr.1.2019.10.03.07.02.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2019 07:02:50 -0700 (PDT) Subject: Re: [PATCH][gdb] Only force INTERP_CONSOLE ui_out for breakpoint commands in MI mode To: Tom de Vries , Andrew Burgess References: <20190905095815.GA27717@delia> <20190924173122.GN4962@embecosm.com> <20190925083642.GO4962@embecosm.com> <6a13b015-6b46-a2a3-0d6b-89a01ef3ab16@suse.de> <6dc5e6b5-4f63-23a8-581b-c78a184d8f08@suse.de> <817a4663-ff93-57dc-d067-e8ee7b8a2804@redhat.com> <03ba9add-28c6-ab08-1d96-920d8a57bf67@suse.de> Cc: gdb-patches@sourceware.org, Tom Tromey , Simon Marchi From: Pedro Alves Message-ID: <52ad768c-5e84-f543-f544-be074364979b@redhat.com> Date: Thu, 03 Oct 2019 14:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <03ba9add-28c6-ab08-1d96-920d8a57bf67@suse.de> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-10/txt/msg00113.txt.bz2 On 10/3/19 2:51 PM, Tom de Vries wrote: > On 03-10-19 14:10, Pedro Alves wrote: >>> --- a/gdb/cli/cli-script.c >>> +++ b/gdb/cli/cli-script.c >>> @@ -697,6 +697,9 @@ execute_control_command_1 (struct command_line *cmd= , int from_tty) >>> enum command_control_type >>> execute_control_command (struct command_line *cmd, int from_tty) >>> { >>> + if (!current_interp_named_p (INTERP_MI)) >>> + return execute_control_command_1 (cmd, from_tty); >> >> Wouldn't we need to handle INTERP_MI1/INTERP_MI2/INTERP_MI3 as well? >> >> Would >> >> if (current_uiout->is_mi_like_p ()) >> >> instead work? >=20 > Yep, that works as well. Patch updated accordingly and re-tested. >=20 > OK for trunk? Seems good to me, but I think we should hear from Andrew as well. Thanks, Pedro Alves