From: Sandra Loosemore <sandra@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Sanimir Agovic <sanimir.agovic@intel.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] nios2-tdep: set default frame base
Date: Wed, 12 Feb 2014 02:24:00 -0000 [thread overview]
Message-ID: <52FADB40.9000600@codesourcery.com> (raw)
In-Reply-To: <52FACC71.8090407@codesourcery.com>
On 02/11/2014 06:20 PM, Yao Qi wrote:
> On 02/11/2014 05:26 PM, Sanimir Agovic wrote:
>> @@ -1595,6 +1595,7 @@ nios2_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>> dwarf2_append_unwinders (gdbarch);
>> frame_unwind_append_unwinder (gdbarch, &nios2_stub_frame_unwind);
>> frame_unwind_append_unwinder (gdbarch, &nios2_frame_unwind);
>> + frame_base_set_default (gdbarch, &nios2_stub_frame_base);
>
> Sanimir,
> some lines below, we have:
>
> frame_unwind_append_unwinder (gdbarch, &nios2_frame_unwind);
>
> /* Single stepping. */
> set_gdbarch_software_single_step (gdbarch, nios2_software_single_step);
>
> /* Hook in ABI-specific overrides, if they have been registered. */
> gdbarch_init_osabi (info, gdbarch);
>
> if (tdep->jb_pc >= 0)
> set_gdbarch_get_longjmp_target (gdbarch, nios2_get_longjmp_target);
>
> frame_base_set_default (gdbarch, &nios2_frame_base);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> so looks we can remove nios2_stub_frame_base.
Removing the unused variable looks like the most conservatively correct
fix to me, too.
Sanimir, thank you for finding this buglet. :-)
-Sandra
next prev parent reply other threads:[~2014-02-12 2:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 9:26 [PATCH 0/2] add calls to frame_base_set_default Sanimir Agovic
2014-02-11 9:26 ` [PATCH 2/2] tic6x-tdep: set default frame base Sanimir Agovic
2014-02-12 0:48 ` Yao Qi
2014-02-11 9:26 ` [PATCH 1/2] nios2-tdep: " Sanimir Agovic
2014-02-12 1:22 ` Yao Qi
2014-02-12 2:24 ` Sandra Loosemore [this message]
2014-02-12 10:04 ` Agovic, Sanimir
2014-02-12 11:36 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FADB40.9000600@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox