Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sanimir Agovic <sanimir.agovic@intel.com>
To: sandra@codesourcery.com, yao@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: [PATCH 0/2] add calls to frame_base_set_default
Date: Tue, 11 Feb 2014 09:26:00 -0000	[thread overview]
Message-ID: <1392110775-21242-1-git-send-email-sanimir.agovic@intel.com> (raw)

Hello,

while removing declared but not referenced variables I came across of two
findings:

 nios2-tdep.c(1350): static const struct frame_base nios2_stub_frame_base
 tic6x-tdep.c(485): static const struct frame_base tic6x_frame_base

Both are declared but not referenced. Instead of removing, I added a call
to frame_base_set_default in the appropriated *_gdbarch_init function and
passed the frame_base structure.
Build with --enable-targets=all, but I could not test my change on actual
hardware.

Looking back at the history it seems that these mentioned variables have
never been used. So removing them might be an alternative to this patch.

Sanimir Agovic (2):
  nios2-tdep: set default frame base
  tic6x-tdep: set default frame base

 gdb/nios2-tdep.c | 1 +
 gdb/tic6x-tdep.c | 1 +
 2 files changed, 2 insertions(+)

-- 
1.8.4.2


             reply	other threads:[~2014-02-11  9:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11  9:26 Sanimir Agovic [this message]
2014-02-11  9:26 ` [PATCH 1/2] nios2-tdep: set default frame base Sanimir Agovic
2014-02-12  1:22   ` Yao Qi
2014-02-12  2:24     ` Sandra Loosemore
2014-02-12 10:04     ` Agovic, Sanimir
2014-02-12 11:36       ` Yao Qi
2014-02-11  9:26 ` [PATCH 2/2] tic6x-tdep: " Sanimir Agovic
2014-02-12  0:48   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392110775-21242-1-git-send-email-sanimir.agovic@intel.com \
    --to=sanimir.agovic@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sandra@codesourcery.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox