From: Pedro Alves <palves@redhat.com>
To: Will Newton <will.newton@linaro.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH] gdb/elfread.c: Enable ifunc support on ARM.
Date: Mon, 10 Feb 2014 15:57:00 -0000 [thread overview]
Message-ID: <52F8F6C7.1040206@redhat.com> (raw)
In-Reply-To: <CANu=DmhH9dtJ2LRRdfFhpERWhAER4e_gEaHHUDQqStqYWA6GCA@mail.gmail.com>
On 02/10/2014 02:57 PM, Will Newton wrote:
> Thanks for taking a look.
>
>> Couple notes:
>>
>> - I think you can look at 'get_elf_backend_data (abfd)->want_got_plt'
>> to decide whether to look up ".got" vs ".got.plt".
>
> I don't think that will work. We actually want to look at the value of
> SEPARATE_GOTPLT I believe, which I don't think we can easily
> determine. For example, ARM sets want_got_plt but not SEPARATE_GOTPLT.
Alright. Lets go with your original patch then. Patch is OK.
Thanks,
--
Pedro Alves
prev parent reply other threads:[~2014-02-10 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 18:24 Will Newton
2014-01-23 15:21 ` Will Newton
2014-02-04 11:28 ` Will Newton
2014-02-06 17:43 ` Pedro Alves
2014-02-10 14:57 ` Will Newton
2014-02-10 15:57 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F8F6C7.1040206@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=patches@linaro.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox