From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1654 invoked by alias); 10 Feb 2014 15:57:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1642 invoked by uid 89); 10 Feb 2014 15:57:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2014 15:57:01 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1AFuw0a005760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Feb 2014 10:56:59 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s1AFuurx017040; Mon, 10 Feb 2014 10:56:57 -0500 Message-ID: <52F8F6C7.1040206@redhat.com> Date: Mon, 10 Feb 2014 15:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Will Newton CC: "gdb-patches@sourceware.org" , Patch Tracking Subject: Re: [PATCH] gdb/elfread.c: Enable ifunc support on ARM. References: <52AF4563.2090304@linaro.org> <52F3C99F.5060500@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00314.txt.bz2 On 02/10/2014 02:57 PM, Will Newton wrote: > Thanks for taking a look. > >> Couple notes: >> >> - I think you can look at 'get_elf_backend_data (abfd)->want_got_plt' >> to decide whether to look up ".got" vs ".got.plt". > > I don't think that will work. We actually want to look at the value of > SEPARATE_GOTPLT I believe, which I don't think we can easily > determine. For example, ARM sets want_got_plt but not SEPARATE_GOTPLT. Alright. Lets go with your original patch then. Patch is OK. Thanks, -- Pedro Alves