From: Pedro Alves <palves@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix generic address check in gdb.base/dump.exp
Date: Wed, 05 Feb 2014 15:25:00 -0000 [thread overview]
Message-ID: <52F257ED.4020800@redhat.com> (raw)
In-Reply-To: <201402051324.s15DOR24007610@glazunov.sibelius.xs4all.nl>
On 02/05/2014 01:24 PM, Mark Kettenis wrote:
> Moves the check until after the inferior has been started such that we
> get the right result for PIEs (position independent executables). The
> addresses of the unrelocated executable tend to be small, but
> relocation is likely to move them above the 4GB boundary.
Doesn't that mean that the set of ran tests potentially
changes depending on the whim of the loader? A more robust
change would disable PIE, similarly to how we pass -Wl,-taso
on alpha, IMO.
>
> ok?
Fine with me, but ...
> 2014-02-05 Mark Kettenis <kettenis@gnu.org>
>
> * gdb.base/dump.exp: Move the generic data address to set
> is64bitonly after starting the inferior to get the correct outcome
> for PIEs.
... I think this "why" remark should be a note in the test itself.
Something like: "Note we check this only after starting the inferior
to get the correct outcome for PIEs.".
Thanks,
--
Pedro Alves
prev parent reply other threads:[~2014-02-05 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 13:24 Mark Kettenis
2014-02-05 15:25 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F257ED.4020800@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox