From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13988 invoked by alias); 5 Feb 2014 15:25:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13976 invoked by uid 89); 5 Feb 2014 15:25:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Feb 2014 15:25:38 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s15FPYsr011241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Feb 2014 10:25:35 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s15FPXB1031557; Wed, 5 Feb 2014 10:25:34 -0500 Message-ID: <52F257ED.4020800@redhat.com> Date: Wed, 05 Feb 2014 15:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix generic address check in gdb.base/dump.exp References: <201402051324.s15DOR24007610@glazunov.sibelius.xs4all.nl> In-Reply-To: <201402051324.s15DOR24007610@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00041.txt.bz2 On 02/05/2014 01:24 PM, Mark Kettenis wrote: > Moves the check until after the inferior has been started such that we > get the right result for PIEs (position independent executables). The > addresses of the unrelocated executable tend to be small, but > relocation is likely to move them above the 4GB boundary. Doesn't that mean that the set of ran tests potentially changes depending on the whim of the loader? A more robust change would disable PIE, similarly to how we pass -Wl,-taso on alpha, IMO. > > ok? Fine with me, but ... > 2014-02-05 Mark Kettenis > > * gdb.base/dump.exp: Move the generic data address to set > is64bitonly after starting the inferior to get the correct outcome > for PIEs. ... I think this "why" remark should be a note in the test itself. Something like: "Note we check this only after starting the inferior to get the correct outcome for PIEs.". Thanks, -- Pedro Alves