From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>, <marc.khouzam@ericsson.com>
Subject: Re: [PATCH 0/2] Create inferior fro trace file target
Date: Wed, 05 Feb 2014 12:17:00 -0000 [thread overview]
Message-ID: <52F22B49.2050802@codesourcery.com> (raw)
In-Reply-To: <52F15433.5070305@redhat.com>
On 02/05/2014 04:57 AM, Pedro Alves wrote:
> I think the availability of the specific process id and thread ids
> is a bit orthogonal to GDB modelling the existence of
> processes/threads or not. We can always say that "there's a process,
> but we don't know its PID". In fact, we do that for cores too.
> That's the real question -- what model makes sense.
I don't have any questions to the model in this case, however, I don't
understand why Eclipse thinks "there must be a PID in the GDB trace
file". Since Eclipse behaves in this way for a while, I have to accept
that.
> We've moved in the direction of "always a thread" a while ago,
What is "always a thread"? Can you elaborate?
>
> In any case, both patches look OK to me, and I agree it's best to
> avoid breaking Eclipse since we don't have a really good reason to
> change behavior compared to previous releases right now. So, OK
> for both. Thanks for fixing this.
Thanks for the review. Two patches are pushed to both mainline and 7.7
branch.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-02-05 12:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 5:46 Yao Qi
2014-01-30 5:46 ` [PATCH 1/2] Create inferior for tfile target Yao Qi
2014-01-30 5:47 ` [PATCH 2/2] Create inferior for ctf target Yao Qi
2014-01-30 19:21 ` [PATCH 0/2] Create inferior fro trace file target Marc Khouzam
2014-02-05 12:54 ` Yao Qi
2014-02-04 20:57 ` Pedro Alves
2014-02-04 21:08 ` Marc Khouzam
2014-02-04 21:17 ` Pedro Alves
2014-02-05 2:05 ` Joel Brobecker
2014-02-05 12:17 ` Yao Qi [this message]
2014-02-05 12:24 ` Joel Brobecker
2014-02-05 12:31 ` Pedro Alves
2014-02-05 12:42 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F22B49.2050802@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox