Re: [PATCH 0/2] Create inferior fro trace file target

Yao Qi
2014-02-05T12:17:24Z

On 02/05/2014 04:57 AM, Pedro Alves wrote:

> I think the availability of the specific process id and thread ids
> is a bit orthogonal to GDB modelling the existence of
> processes/threads or not. We can always say that "there's a process,
> but we don't know its PID". In fact, we do that for cores too.
> That's the real question -- what model makes sense.

I don't have any questions to the model in this case, however, I don't
understand why Eclipse thinks "there must be a PID in the GDB trace
file". Since Eclipse behaves in this way for a while, I have to accept
that.

> We've moved in the direction of "always a thread" a while ago,

What is "always a thread"? Can you elaborate?

>
> In any case, both patches look OK to me, and I agree it's best to
> avoid breaking Eclipse since we don't have a really good reason to
> change behavior compared to previous releases right now. So, OK
> for both. Thanks for fixing this.

Thanks for the review. Two patches are pushed to both mainline and 7.7
branch.

--
Yao (é½å°§)