From: Tristan Gingold <gingold@adacore.com>
To: gdb-patches@sourceware.org
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [RFA] Darwin/x86 port (v2 - part 3: i386-darwin files)
Date: Wed, 12 Nov 2008 17:21:00 -0000 [thread overview]
Message-ID: <52BA465D-9D03-4F53-BD26-7C48520BBA0F@adacore.com> (raw)
In-Reply-To: <200811121242.mACCgGit009483@brahms.sibelius.xs4all.nl>
On Nov 12, 2008, at 1:42 PM, Mark Kettenis wrote:
>> void i386_darwin_fetch_gp_registers (struct regcache *regcache,
>> i386_thread_state_t *sp_regs);
>> void i386_darwin_store_gp_registers (struct regcache *regcache,
>> i386_thread_state_t *sp_regs);
>> void x86_64_darwin_fetch_gp_registers (struct regcache *regcache,
>> x86_thread_state64_t *sp_regs);
>> void x86_64_darwin_store_gp_registers (struct regcache *regcache,
>> x86_thread_state64_t *sp_regs);
>> void i386_darwin_fetch_fp_registers (struct regcache *regcache,
>> i386_float_state_t *fp_regs);
>> int i386_darwin_store_fp_registers (struct regcache *regcache,
>> i386_float_state_t *fp_regs);
>> void x86_64_darwin_fetch_fp_registers (struct regcache *regcache,
>> x86_float_state64_t *fp_regs);
>> int x86_64_darwin_store_fp_registers (struct regcache *regcache,
>> x86_float_state64_t *fp_regs);
>
> Can you do a s/x86_64/amd64/ on the function/variable names in your
> new code? That's more consistent with other code in GDB.
Ok.
>> #define INVALID_ADDRESS ((CORE_ADDR) (-1))
>
> As far as I can tell, this define isn't used. Can you remove it?
Sure.
I will resubmit this part.
Tristan.
next prev parent reply other threads:[~2008-11-12 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 18:40 Tristan Gingold
2008-11-12 12:43 ` Tristan Gingold
2008-11-12 16:39 ` Mark Kettenis
2008-11-12 17:21 ` Tristan Gingold [this message]
2008-11-12 20:21 ` Tristan Gingold
2008-11-13 14:53 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BA465D-9D03-4F53-BD26-7C48520BBA0F@adacore.com \
--to=gingold@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox