From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5076 invoked by alias); 12 Nov 2008 12:50:43 -0000 Received: (qmail 5029 invoked by uid 22791); 12 Nov 2008 12:50:42 -0000 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Nov 2008 12:50:06 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id B6DBA290009; Wed, 12 Nov 2008 13:50:03 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V6r2CwKDQ9pX; Wed, 12 Nov 2008 13:50:03 +0100 (CET) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.0.139]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 1BC26290007; Wed, 12 Nov 2008 13:50:03 +0100 (CET) Cc: Mark Kettenis Message-Id: <52BA465D-9D03-4F53-BD26-7C48520BBA0F@adacore.com> From: Tristan Gingold To: gdb-patches@sourceware.org In-Reply-To: <200811121242.mACCgGit009483@brahms.sibelius.xs4all.nl> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Subject: Re: [RFA] Darwin/x86 port (v2 - part 3: i386-darwin files) Date: Wed, 12 Nov 2008 17:21:00 -0000 References: <20081112101250.GA18396@ulanbator.act-europe.fr> <200811121242.mACCgGit009483@brahms.sibelius.xs4all.nl> X-Mailer: Apple Mail (2.929.2) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00234.txt.bz2 On Nov 12, 2008, at 1:42 PM, Mark Kettenis wrote: >> void i386_darwin_fetch_gp_registers (struct regcache *regcache, >> i386_thread_state_t *sp_regs); >> void i386_darwin_store_gp_registers (struct regcache *regcache, >> i386_thread_state_t *sp_regs); >> void x86_64_darwin_fetch_gp_registers (struct regcache *regcache, >> x86_thread_state64_t *sp_regs); >> void x86_64_darwin_store_gp_registers (struct regcache *regcache, >> x86_thread_state64_t *sp_regs); >> void i386_darwin_fetch_fp_registers (struct regcache *regcache, >> i386_float_state_t *fp_regs); >> int i386_darwin_store_fp_registers (struct regcache *regcache, >> i386_float_state_t *fp_regs); >> void x86_64_darwin_fetch_fp_registers (struct regcache *regcache, >> x86_float_state64_t *fp_regs); >> int x86_64_darwin_store_fp_registers (struct regcache *regcache, >> x86_float_state64_t *fp_regs); > > Can you do a s/x86_64/amd64/ on the function/variable names in your > new code? That's more consistent with other code in GDB. Ok. >> #define INVALID_ADDRESS ((CORE_ADDR) (-1)) > > As far as I can tell, this define isn't used. Can you remove it? Sure. I will resubmit this part. Tristan.