From: Pedro Alves <palves@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: 74 columns for ChangeLogs? [was Re: [PATCH 1/6] gdbserver (linux_debug): Remove extraneous \n from output.]
Date: Wed, 18 Dec 2013 17:43:00 -0000 [thread overview]
Message-ID: <52B1DEBE.5010905@redhat.com> (raw)
In-Reply-To: <CADPb22RCz29jtrtnk5sd+OVP7nB34O-b9j+sig-MhcC-PQU7mg@mail.gmail.com>
On 12/18/2013 05:28 PM, Doug Evans wrote:
> On Wed, Dec 18, 2013 at 3:13 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 12/17/2013 09:40 PM, Doug Evans wrote:
>>> 2013-12-17 Doug Evans <dje@google.com>
>>>
>>> * nat/linux-waitpid.c (linux_debug): Remove extraneous \n from output.
>>
>> (Line too long. fill-column is 74 for ChangeLogs)
>
> Is that a hard and fast rule now, or just a nice to have.
It's not a new rule. It's been that way since forever.
It's emacs's default in changelog mode, and also what most
ChangeLog files in the tree have explicitly at the bottom:
fill-column: 74
So M-q in ChangeLog should be doing that for you automatically.
And also mentioned in the ContributionCheckist wiki page.
> I always understood it to be a nice-to-have:
> I don't have to look very far into ChangeLog to find a plethora of
> violations from various people, and I know I didn't review all those
> patches.
Sure, bugs and wrong formatting always pass through review all
the time. What's the point? Honestly, I was just expecting
you'd say something like "whoops, forgot to M-q", but it
sounds like you did it on purpose. This was already discussed
not so long ago, and I didn't mean to open yet another discussion,
so I'm already regretting I pointed it out.
--
Pedro Alves
prev parent reply other threads:[~2013-12-18 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 17:28 Doug Evans
2013-12-18 17:43 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B1DEBE.5010905@redhat.com \
--to=palves@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox