From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19324 invoked by alias); 18 Dec 2013 17:43:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19313 invoked by uid 89); 18 Dec 2013 17:43:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2013 17:43:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIHhSX7028086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Dec 2013 12:43:28 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBIHhRkR002761; Wed, 18 Dec 2013 12:43:27 -0500 Message-ID: <52B1DEBE.5010905@redhat.com> Date: Wed, 18 Dec 2013 17:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches Subject: Re: 74 columns for ChangeLogs? [was Re: [PATCH 1/6] gdbserver (linux_debug): Remove extraneous \n from output.] References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00716.txt.bz2 On 12/18/2013 05:28 PM, Doug Evans wrote: > On Wed, Dec 18, 2013 at 3:13 AM, Pedro Alves wrote: >> On 12/17/2013 09:40 PM, Doug Evans wrote: >>> 2013-12-17 Doug Evans >>> >>> * nat/linux-waitpid.c (linux_debug): Remove extraneous \n from output. >> >> (Line too long. fill-column is 74 for ChangeLogs) > > Is that a hard and fast rule now, or just a nice to have. It's not a new rule. It's been that way since forever. It's emacs's default in changelog mode, and also what most ChangeLog files in the tree have explicitly at the bottom: fill-column: 74 So M-q in ChangeLog should be doing that for you automatically. And also mentioned in the ContributionCheckist wiki page. > I always understood it to be a nice-to-have: > I don't have to look very far into ChangeLog to find a plethora of > violations from various people, and I know I didn't review all those > patches. Sure, bugs and wrong formatting always pass through review all the time. What's the point? Honestly, I was just expecting you'd say something like "whoops, forgot to M-q", but it sounds like you did it on purpose. This was already discussed not so long ago, and I didn't mean to open yet another discussion, so I'm already regretting I pointed it out. -- Pedro Alves