From: Pedro Alves <palves@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/6] gdbserver: remove function abbrevs from debugging text
Date: Wed, 18 Dec 2013 11:16:00 -0000 [thread overview]
Message-ID: <52B183FF.5090601@redhat.com> (raw)
In-Reply-To: <CADPb22RcEojD3TYbRB7fn9yj3EV00tXAYh8n3PC-4FFmYOX-0Q@mail.gmail.com>
On 12/18/2013 01:20 AM, Doug Evans wrote:
> On Tue, Dec 17, 2013 at 4:41 PM, Yao Qi <yao@codesourcery.com> wrote:
>> On 12/18/2013 05:43 AM, Doug Evans wrote:
>>> This patch removes the function abbreviations from the debugging output.
>>
>> Function abbreviations are also mentioned in linux-nat debugging output.
>> IWBN to keep them consistent.
>
> Sure. I'll submit a separate patch for that.
>
>>> In one example it's wrong (GPS vs get_detach_signal), and I rarely
>>> keep in cache the translation to function name.
>>
>> The function names in debugging output will be out of sync as function
>> names are changed, unless macro __func__ is used. However, __func__
>> is defined in C99 and we are using C90 (?) in GDB.
>
> I think it's reasonable to do what we do for gdb_assert, namely just
> punt on printing the name if the feature isn't present.
Yeah. FAOD, I think using __PRETTY_FUNCTION__/__func__
would be great.
--
Pedro Alves
next prev parent reply other threads:[~2013-12-18 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 21:43 Doug Evans
2013-12-18 0:42 ` Yao Qi
2013-12-18 1:20 ` Doug Evans
2013-12-18 1:57 ` Yao Qi
2013-12-18 11:16 ` Pedro Alves [this message]
2013-12-18 15:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B183FF.5090601@redhat.com \
--to=palves@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox