From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31439 invoked by alias); 18 Dec 2013 11:16:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31425 invoked by uid 89); 18 Dec 2013 11:16:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2013 11:16:21 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIBGI55006377 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Dec 2013 06:16:18 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBIBGG0h001723; Wed, 18 Dec 2013 06:16:17 -0500 Message-ID: <52B183FF.5090601@redhat.com> Date: Wed, 18 Dec 2013 11:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Doug Evans CC: Yao Qi , gdb-patches Subject: Re: [PATCH 2/6] gdbserver: remove function abbrevs from debugging text References: <52B0EF1E.7080302@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00692.txt.bz2 On 12/18/2013 01:20 AM, Doug Evans wrote: > On Tue, Dec 17, 2013 at 4:41 PM, Yao Qi wrote: >> On 12/18/2013 05:43 AM, Doug Evans wrote: >>> This patch removes the function abbreviations from the debugging output. >> >> Function abbreviations are also mentioned in linux-nat debugging output. >> IWBN to keep them consistent. > > Sure. I'll submit a separate patch for that. > >>> In one example it's wrong (GPS vs get_detach_signal), and I rarely >>> keep in cache the translation to function name. >> >> The function names in debugging output will be out of sync as function >> names are changed, unless macro __func__ is used. However, __func__ >> is defined in C99 and we are using C90 (?) in GDB. > > I think it's reasonable to do what we do for gdb_assert, namely just > punt on printing the name if the feature isn't present. Yeah. FAOD, I think using __PRETTY_FUNCTION__/__func__ would be great. -- Pedro Alves