From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Gabriel Krisman Bertazi <gabriel@krisman.be>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix for PR breakpoints/16297: Fix catch syscall to work with syscall 0
Date: Mon, 16 Dec 2013 17:51:00 -0000 [thread overview]
Message-ID: <52AF3DA0.3020406@redhat.com> (raw)
In-Reply-To: <m3mwk24v5w.fsf@redhat.com>
On 12/15/2013 04:04 AM, Sergio Durigan Junior wrote:
> On Sunday, December 15 2013, Gabriel Krisman Bertazi wrote:
>
>> This is a fix for bug 16297. The problem occurs when the user attempts
>> to catch any syscall 0 (such as syscall read on Linux/x86_64). GDB was
>> not able to catch the syscall and was missing the breakpoint.
>>
>> Now, breakpoint_hit_catch_syscall returns immediately when it finds the
>> correct syscall number, avoiding a following check for the end of the
>> search vector, that returns a no hit if the syscall number was zero.
>
> Thanks.
>
> Just for the record, I pre-reviewed Krisman's patch and it's OK. I am
> also helping him in obtaining the copyright assignment.
Thanks you both. FAOD, this is OK.
> I will send a patch to test this feature as soon as my other patch
> (which touches catch-syscall.exp and improves it) gets approved.
--
Pedro Alves
next prev parent reply other threads:[~2013-12-16 17:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 3:58 Gabriel Krisman Bertazi
2013-12-15 4:04 ` Sergio Durigan Junior
2013-12-16 17:51 ` Pedro Alves [this message]
2013-12-16 17:57 ` Pedro Alves
2013-12-16 18:03 ` Sergio Durigan Junior
2013-12-16 18:35 ` Pedro Alves
2013-12-19 3:50 ` Sergio Durigan Junior
2013-12-19 16:21 ` Pedro Alves
2013-12-19 19:09 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF3DA0.3020406@redhat.com \
--to=palves@redhat.com \
--cc=gabriel@krisman.be \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox