From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27972 invoked by alias); 16 Dec 2013 17:51:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27951 invoked by uid 89); 16 Dec 2013 17:51:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2013 17:51:33 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBGHpULU023132 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Dec 2013 12:51:30 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBGHpS9Y009393; Mon, 16 Dec 2013 12:51:28 -0500 Message-ID: <52AF3DA0.3020406@redhat.com> Date: Mon, 16 Dec 2013 17:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergio Durigan Junior CC: Gabriel Krisman Bertazi , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix for PR breakpoints/16297: Fix catch syscall to work with syscall 0 References: <87fvpu4vgh.fsf@lestat.krisman.be> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00588.txt.bz2 On 12/15/2013 04:04 AM, Sergio Durigan Junior wrote: > On Sunday, December 15 2013, Gabriel Krisman Bertazi wrote: > >> This is a fix for bug 16297. The problem occurs when the user attempts >> to catch any syscall 0 (such as syscall read on Linux/x86_64). GDB was >> not able to catch the syscall and was missing the breakpoint. >> >> Now, breakpoint_hit_catch_syscall returns immediately when it finds the >> correct syscall number, avoiding a following check for the end of the >> search vector, that returns a no hit if the syscall number was zero. > > Thanks. > > Just for the record, I pre-reviewed Krisman's patch and it's OK. I am > also helping him in obtaining the copyright assignment. Thanks you both. FAOD, this is OK. > I will send a patch to test this feature as soon as my other patch > (which touches catch-syscall.exp and improves it) gets approved. -- Pedro Alves