From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] nameless LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing
Date: Fri, 13 Dec 2013 14:42:00 -0000 [thread overview]
Message-ID: <52AB1CC1.8040507@redhat.com> (raw)
In-Reply-To: <20131213141723.GB3255@adacore.com>
Looks OK to me. Thanks.
On 12/13/2013 02:17 PM, Joel Brobecker wrote:
> +
> + win32_ensure_ntdll_loaded ();
> }
(
Though it's harmless as is, there's no ntdll.dll on CE, only on
Windows versions with NT based kernels. To be consistent
with what we do elsewhere on the file already when
treating ntdll.dll especially, this could be:
#ifndef _WIN32_WCE
win32_ensure_ntdll_loaded ();
#endif
)
--
Pedro Alves
next prev parent reply other threads:[~2013-12-13 14:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 11:31 Joel Brobecker
2013-12-03 19:51 ` Pedro Alves
2013-12-03 20:11 ` Eli Zaretskii
2013-12-05 10:54 ` Joel Brobecker
2013-12-05 12:38 ` Pedro Alves
2013-12-09 11:33 ` Joel Brobecker
2013-12-09 17:08 ` Pedro Alves
2013-12-10 10:06 ` pushed: " Joel Brobecker
2013-12-10 10:06 ` Joel Brobecker
2013-12-10 10:56 ` Joel Brobecker
2013-12-10 13:41 ` Pedro Alves
2013-12-10 13:58 ` Pedro Alves
2013-12-12 18:18 ` Joel Brobecker
2013-12-12 18:51 ` Eli Zaretskii
2013-12-12 19:08 ` Pedro Alves
2013-12-12 22:06 ` Tom Tromey
2013-12-13 10:06 ` Pedro Alves
2013-12-13 11:04 ` Joel Brobecker
2013-12-13 11:21 ` Pedro Alves
2013-12-13 19:38 ` Tom Tromey
2013-12-13 14:17 ` Joel Brobecker
2013-12-13 14:42 ` Pedro Alves [this message]
2013-12-13 15:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AB1CC1.8040507@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox