Re: [PATCH] Call get_compiler_info directly from test_compiler_info if needed.

[Andrew Burgess <aburgess@broadcom.com>]

On 10/12/2013 3:00 PM, Pedro Alves wrote:
> On 12/10/2013 02:43 PM, Andrew Burgess wrote:
>>  proc test_compiler_info { {compiler ""} } {
>>      global compiler_info
>>  
>> +    # Check that compiler_info has been initialised
>> +    if [string match "" $compiler_info] {
>> +	if [get_compiler_info] {
>> +	    warning "Could not get compiler info"
>> +	    return -1
>> +	}
>> +    }
> 
> What about get_compiler_info's $arg?

In the cases where I removed calls to get_compiler_info no arg was being
passed anyway, my assumption then is that in most cases the "default"
result of get_compiler_info is fine.

If you really want to pass some args to get_compiler_info you can still
do that in a separate call, and I left in place (in gdb.exp) a call that
does just this.

The code in test_compiler_info will not overwrite an existing
compiler_info value, so if you've taken care to call get_compiler_info
yourself then all should still work as expected.

Thanks,
Andrew