Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Call get_compiler_info directly from test_compiler_info if needed.
Date: Tue, 10 Dec 2013 15:07:00 -0000	[thread overview]
Message-ID: <52A72C70.5040305@redhat.com> (raw)
In-Reply-To: <52A728A0.1050208@broadcom.com>

On 12/10/2013 02:43 PM, Andrew Burgess wrote:
>  proc test_compiler_info { {compiler ""} } {
>      global compiler_info
>  
> +    # Check that compiler_info has been initialised
> +    if [string match "" $compiler_info] {
> +	if [get_compiler_info] {
> +	    warning "Could not get compiler info"
> +	    return -1
> +	}
> +    }

What about get_compiler_info's $arg?

-- 
Pedro Alves


  reply	other threads:[~2013-12-10 15:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 14:43 Andrew Burgess
2013-12-10 15:07 ` Pedro Alves [this message]
2013-12-10 15:16   ` Andrew Burgess
2013-12-10 15:49     ` Pedro Alves
2013-12-10 16:10       ` Call get_compiler_info before test_compiler_info. (was: Re: [PATCH] Call get_compiler_info directly from test_compiler_info if needed.) Andrew Burgess
2013-12-10 16:26         ` Call get_compiler_info before test_compiler_info Pedro Alves
2013-12-10 17:10           ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A72C70.5040305@redhat.com \
    --to=palves@redhat.com \
    --cc=aburgess@broadcom.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox