From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Allow Windows UNWIND_INFO version 2.
Date: Tue, 03 Dec 2013 18:47:00 -0000 [thread overview]
Message-ID: <529E274D.607@redhat.com> (raw)
In-Reply-To: <1386070345-8237-1-git-send-email-brobecker@adacore.com>
On 12/03/2013 11:32 AM, Joel Brobecker wrote:
> @@ -696,7 +697,17 @@ amd64_windows_frame_decode_insns (struct frame_info *this_frame,
> return;
>
> end_insns = &insns[codes_count * 2];
> - for (p = insns; p < end_insns; p += 2)
> + p = insns;
> +
> + /* Skip opcodes 6 of version 2. This opcode is not documented. */
> + if (PEX64_UWI_VERSION (ex_ui.Version_Flags) == 2)
> + {
> + for (; p < end_insns; p += 2)
> + if (PEX64_UNWCODE_CODE (p[1]) != 6)
> + break;
> + }
I'd consider merging with the existing loop, so that
we print the opcodes when frame debug is enabled.
But anyway, this looks fine to me.
I clicked on "Did you find this helpful? No" at:
http://msdn.microsoft.com/en-us/library/ck9asaa9.aspx
and asked for info about v2 and opcode 6. Not holding
my breath though.
--
Pedro Alves
next prev parent reply other threads:[~2013-12-03 18:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 11:32 Joel Brobecker
2013-12-03 18:47 ` Pedro Alves [this message]
2013-12-03 19:58 ` Corinna Vinschen
2013-12-03 20:04 ` Corinna Vinschen
2013-12-04 8:40 ` Tristan Gingold
2013-12-04 8:43 ` Tristan Gingold
2013-12-05 3:45 ` Joel Brobecker
2013-12-09 10:43 ` Corinna Vinschen
2013-12-09 11:47 ` Tristan Gingold
2013-12-09 12:11 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E274D.607@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox