From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32366 invoked by alias); 3 Dec 2013 18:47:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32356 invoked by uid 89); 3 Dec 2013 18:47:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2013 18:47:52 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB3Ilh9b007881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Dec 2013 13:47:43 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rB3Ilfhu005216; Tue, 3 Dec 2013 13:47:42 -0500 Message-ID: <529E274D.607@redhat.com> Date: Tue, 03 Dec 2013 18:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFA] Allow Windows UNWIND_INFO version 2. References: <1386070345-8237-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1386070345-8237-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00089.txt.bz2 On 12/03/2013 11:32 AM, Joel Brobecker wrote: > @@ -696,7 +697,17 @@ amd64_windows_frame_decode_insns (struct frame_info *this_frame, > return; > > end_insns = &insns[codes_count * 2]; > - for (p = insns; p < end_insns; p += 2) > + p = insns; > + > + /* Skip opcodes 6 of version 2. This opcode is not documented. */ > + if (PEX64_UWI_VERSION (ex_ui.Version_Flags) == 2) > + { > + for (; p < end_insns; p += 2) > + if (PEX64_UNWCODE_CODE (p[1]) != 6) > + break; > + } I'd consider merging with the existing loop, so that we print the opcodes when frame debug is enabled. But anyway, this looks fine to me. I clicked on "Did you find this helpful? No" at: http://msdn.microsoft.com/en-us/library/ck9asaa9.aspx and asked for info about v2 and opcode 6. Not holding my breath though. -- Pedro Alves