From: Phil Muldoon <pmuldoon@redhat.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Python's gdb.FRAME_UNWIND_NULL_ID is no longer used. What to do with it?
Date: Thu, 28 Nov 2013 23:01:00 -0000 [thread overview]
Message-ID: <5297B2BF.9010401@redhat.com> (raw)
In-Reply-To: <1385664356-29726-1-git-send-email-palves@redhat.com>
On 28/11/13 18:45, Pedro Alves wrote:
> I'd assume scripts just check the result of Frame.unwind_stop_reason,
> and compare it to gdb.FRAME_UNWIND_NO_REASON. That at most, they'll
> pass the result of Frame.unwind_stop_reason to
> gdb.frame_stop_reason_string. I'd prefer to just get rid of it, but
> it may be best to keep this around for compatibility, in case a script
> does refer to gdb.FRAME_UNWIND_NULL_ID directly.
>
> In general, what's the policy for exposed constants like this in
> Python?
>
> gdb/
> 2013-11-28 Pedro Alves <palves@redhat.com>
>
> * unwind_stop_reasons.def (UNWIND_NULL_ID): Update comment.
>
> gdb/doc/
> 2013-11-28 Pedro Alves <palves@redhat.com>
>
> * gdb.texinfo (Frames In Python) <gdb.FRAME_UNWIND_NULL_ID>:
> Update comment.
> ---
As a script could check it, and because we make an API promise, we
really have to leave it in there. You have done the correct
thing by documenting the deprecated nature of the constant.
It might be time to think about what the API pertains too. GDB
evolves constantly, and I really don't want Python in a few years from
now to be full of deprecated functions/constants.
OK by me.
Cheers,
Phil
next prev parent reply other threads:[~2013-11-28 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 20:13 Pedro Alves
2013-11-28 21:16 ` Eli Zaretskii
2013-11-28 23:01 ` Phil Muldoon [this message]
2013-11-29 17:22 ` Pedro Alves
2013-12-02 16:10 ` Tom Tromey
2013-12-12 17:25 ` Pedro Alves
2013-12-12 17:37 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5297B2BF.9010401@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox