From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25339 invoked by alias); 28 Nov 2013 21:16:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25327 invoked by uid 89); 28 Nov 2013 21:16:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Nov 2013 21:16:56 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rASLGnI4000866 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Nov 2013 16:16:49 -0500 Received: from localhost.localdomain (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rASLGlJD000305; Thu, 28 Nov 2013 16:16:48 -0500 Message-ID: <5297B2BF.9010401@redhat.com> Date: Thu, 28 Nov 2013 23:01:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [RFC] Python's gdb.FRAME_UNWIND_NULL_ID is no longer used. What to do with it? References: <1385664356-29726-1-git-send-email-palves@redhat.com> In-Reply-To: <1385664356-29726-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00894.txt.bz2 On 28/11/13 18:45, Pedro Alves wrote: > I'd assume scripts just check the result of Frame.unwind_stop_reason, > and compare it to gdb.FRAME_UNWIND_NO_REASON. That at most, they'll > pass the result of Frame.unwind_stop_reason to > gdb.frame_stop_reason_string. I'd prefer to just get rid of it, but > it may be best to keep this around for compatibility, in case a script > does refer to gdb.FRAME_UNWIND_NULL_ID directly. > > In general, what's the policy for exposed constants like this in > Python? > > gdb/ > 2013-11-28 Pedro Alves > > * unwind_stop_reasons.def (UNWIND_NULL_ID): Update comment. > > gdb/doc/ > 2013-11-28 Pedro Alves > > * gdb.texinfo (Frames In Python) : > Update comment. > --- As a script could check it, and because we make an API promise, we really have to leave it in there. You have done the correct thing by documenting the deprecated nature of the constant. It might be time to think about what the API pertains too. GDB evolves constantly, and I really don't want Python in a few years from now to be full of deprecated functions/constants. OK by me. Cheers, Phil