From: Phil Muldoon <pmuldoon@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch][python] 1/3 Python representation of GDB line tables (Python code)
Date: Mon, 11 Nov 2013 21:03:00 -0000 [thread overview]
Message-ID: <528135D3.4090307@redhat.com> (raw)
In-Reply-To: <21117.6425.284003.919541@ruffy.mtv.corp.google.com>
On 08/11/13 17:02, Doug Evans wrote:
> Phil Muldoon writes:
> > I've made the requested changes. For the sake of brevity I have just
> > included the three file diffs this time around instead of mailing the
> > whole series.
> >
> > This OK?
>
> Thanks.
>
> "works for me"
>
> [I missed a few things in my previous review. Blech. Mea culpa.
> There's a couple of function comments that don't have a blank
> line between them and their function. How could I have missed that??? :-)
> Ok with those changes, no need for another iteration on my account.
>
> Thanks again.
So committed, with the two header newlines.
Cheers,
Phil
prev parent reply other threads:[~2013-11-11 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 12:04 Phil Muldoon
2013-10-23 20:46 ` Tom Tromey
2013-11-07 16:35 ` Phil Muldoon
2013-11-07 17:08 ` Tom Tromey
2013-11-07 20:42 ` Doug Evans
2013-11-08 14:42 ` Phil Muldoon
2013-11-08 17:08 ` Doug Evans
2013-11-11 21:03 ` Phil Muldoon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528135D3.4090307@redhat.com \
--to=pmuldoon@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox