From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28291 invoked by alias); 11 Nov 2013 19:54:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28277 invoked by uid 89); 11 Nov 2013 19:54:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Nov 2013 19:54:05 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rABJrv0b025325 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Nov 2013 14:53:57 -0500 Received: from localhost.localdomain (ovpn-112-47.ams2.redhat.com [10.36.112.47]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rABJrtNF005292; Mon, 11 Nov 2013 14:53:56 -0500 Message-ID: <528135D3.4090307@redhat.com> Date: Mon, 11 Nov 2013 21:03:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Doug Evans CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [patch][python] 1/3 Python representation of GDB line tables (Python code) References: <5253F4D4.1050600@redhat.com> <87ob6fd8c7.fsf@fleche.redhat.com> <527BC0F3.1080800@redhat.com> <21115.62285.436813.473271@ruffy.mtv.corp.google.com> <527CF370.9030808@redhat.com> <21117.6425.284003.919541@ruffy.mtv.corp.google.com> In-Reply-To: <21117.6425.284003.919541@ruffy.mtv.corp.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00301.txt.bz2 On 08/11/13 17:02, Doug Evans wrote: > Phil Muldoon writes: > > I've made the requested changes. For the sake of brevity I have just > > included the three file diffs this time around instead of mailing the > > whole series. > > > > This OK? > > Thanks. > > "works for me" > > [I missed a few things in my previous review. Blech. Mea culpa. > There's a couple of function comments that don't have a blank > line between them and their function. How could I have missed that??? :-) > Ok with those changes, no need for another iteration on my account. > > Thanks again. So committed, with the two header newlines. Cheers, Phil