From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/6] introduce common.m4
Date: Tue, 05 Nov 2013 19:09:00 -0000 [thread overview]
Message-ID: <5279425C.7020201@redhat.com> (raw)
In-Reply-To: <1383675811-3274-2-git-send-email-tromey@redhat.com>
On 11/05/2013 06:23 PM, Tom Tromey wrote:
> 2013-11-04 Tom Tromey <tromey@redhat.com>
>
> * acinclude.m4: Include common.m4.
> * common/common.m4: New file.
> * configure, config.in: Rebuild.
> * configure.ac: Use GDB_AC_COMMON.
>
> 2013-11-04 Tom Tromey <tromey@redhat.com>
>
> * acinclude.m4: Include common.m4, codeset.m4.
HAVE_LANGINFO_CODESET is used by common/gdb_locale.h,
and GDB_AC_COMMON uses AM_LANGINFO_CODESET. Shouldn't
codeset.m4 then be included by common.m4 instead?
> * configure, config.in: Rebuild.
> * configure.ac: Use GDB_AC_COMMON.
(In cases like these, it's useful to include an indication
of which ChangeLog file each entry goes to. The above
is a case where that wasn't immediately obvious.)
--
Pedro Alves
next prev parent reply other threads:[~2013-11-05 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 18:23 [PATCH v2 0/6] " Tom Tromey
2013-11-05 18:23 ` [PATCH v2 2/6] remove link.h checks Tom Tromey
2013-11-05 19:10 ` Pedro Alves
2013-11-05 18:24 ` [PATCH v2 1/6] introduce common.m4 Tom Tromey
2013-11-05 19:09 ` Pedro Alves [this message]
2013-11-05 20:03 ` Tom Tromey
2013-11-08 12:46 ` Pedro Alves
2013-11-08 19:32 ` Tom Tromey
2013-11-08 20:10 ` Tom Tromey
2013-11-05 18:25 ` [PATCH v2 4/6] gdb configure updates Tom Tromey
2013-11-05 19:10 ` Pedro Alves
2013-11-05 19:09 ` [PATCH v2 3/6] use gdb_string.h in m32c-tdep.c Tom Tromey
2013-11-05 19:49 ` Pedro Alves
2013-11-05 19:10 ` [PATCH v2 0/6] introduce common.m4 Pedro Alves
2013-11-05 20:04 ` [PATCH v2 5/6] fix a comment in configure.ac Tom Tromey
2013-11-05 21:10 ` [PATCH v2 6/6] remove unused gdbserver configury Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5279425C.7020201@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox