From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6538 invoked by alias); 5 Nov 2013 19:09:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6526 invoked by uid 89); 5 Nov 2013 19:09:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2013 19:09:25 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA5J9IbY017847 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Nov 2013 14:09:18 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA5J9GUp031152; Tue, 5 Nov 2013 14:09:17 -0500 Message-ID: <5279425C.7020201@redhat.com> Date: Tue, 05 Nov 2013 19:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/6] introduce common.m4 References: <1383675811-3274-1-git-send-email-tromey@redhat.com> <1383675811-3274-2-git-send-email-tromey@redhat.com> In-Reply-To: <1383675811-3274-2-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00094.txt.bz2 On 11/05/2013 06:23 PM, Tom Tromey wrote: > 2013-11-04 Tom Tromey > > * acinclude.m4: Include common.m4. > * common/common.m4: New file. > * configure, config.in: Rebuild. > * configure.ac: Use GDB_AC_COMMON. > > 2013-11-04 Tom Tromey > > * acinclude.m4: Include common.m4, codeset.m4. HAVE_LANGINFO_CODESET is used by common/gdb_locale.h, and GDB_AC_COMMON uses AM_LANGINFO_CODESET. Shouldn't codeset.m4 then be included by common.m4 instead? > * configure, config.in: Rebuild. > * configure.ac: Use GDB_AC_COMMON. (In cases like these, it's useful to include an indication of which ChangeLog file each entry goes to. The above is a case where that wasn't immediately obvious.) -- Pedro Alves