From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Rewrite the "show environment" test
Date: Tue, 9 Dec 2025 13:22:47 -0500 [thread overview]
Message-ID: <526b07c7-b82d-4096-bb82-580e0d84c55a@simark.ca> (raw)
In-Reply-To: <20251209180230.432182-1-tromey@adacore.com>
On 12/9/25 1:02 PM, Tom Tromey wrote:
> In a review early in the year:
>
> https://inbox.sourceware.org/gdb-patches/874iz3f4ek.fsf@redhat.com/
>
> Andrew pointed out that a new test I proposed failed with read1.
> This test was essentially a copy of gdb.base/environ.exp.
>
> I couldn't reproduce the read1 problem, but this patch rewrites the
> one test there that seems like it could possibly fail in this mode.
> Now it uses line-by-line mode and checks for a certain environment
> variable appearing in the output.
Seems fine to me.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2025-12-09 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 18:02 Tom Tromey
2025-12-09 18:22 ` Simon Marchi [this message]
2025-12-10 8:30 ` Aktemur, Tankut Baris
2025-12-11 22:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526b07c7-b82d-4096-bb82-580e0d84c55a@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox