From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jNsHJRRpOGkqJCkAWB0awg (envelope-from ) for ; Tue, 09 Dec 2025 13:23:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1765304596; bh=n0o3am6RbHP0WYBjb36BGqg94WCLacXxFKP26WZdJlc=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ntew21YUm6vo3VS/Okn/oDm2DWLHqjUGA1GpxT5UiyKx1v5YMuJAqZNCfhdQW0OWc OUknYxiEjg0vcEvm07BIN5ZQLHAXVHz6ipvx9GN7NeokywD+xC8jOhpeGy6RP63vJ0 tStKPxZElN7n6TEqRb+yazlJ3V8k+gSN7inzKuIU= Received: by simark.ca (Postfix, from userid 112) id 866971E0B3; Tue, 09 Dec 2025 13:23:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Z5X+KOd0; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5D6C21E08D for ; Tue, 09 Dec 2025 13:23:15 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 176604BA2E35 for ; Tue, 9 Dec 2025 18:23:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 176604BA2E35 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Z5X+KOd0 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E73AA4BA2E02 for ; Tue, 9 Dec 2025 18:22:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E73AA4BA2E02 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E73AA4BA2E02 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765304569; cv=none; b=pHrl6+gyCrGOYIPuVDICedcNev6vjc5dS8rMcWe7jZCCKHLlJSvj2YGOclNa4ZLzUDzGBucH1/UsmRaojRvzLlaTF/YP8Nfyf41zffBjvmWMFVh/jqroF+Rm2Fc8FqfApjPnnv7NIC4V/fKisQ7+5Jzp2dAezCwpWmq5b97HLog= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765304569; c=relaxed/simple; bh=n0o3am6RbHP0WYBjb36BGqg94WCLacXxFKP26WZdJlc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sI0Q9DR12wZopY+jc2t1cp0MzN9MWc2RtZv7t6a6TOBy0PBeVTaXRMs5wIFEBmGb6WiXaDz9qeg2YzffQRF8Ha/LIkxmcZrdWCuOBO+p8gpdRs88nBrw4IfjshsMuMxPvn/Eac3fDgN17dllHDdkNT+Q5hAkYkdRZK9fgVOBeTg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E73AA4BA2E02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1765304568; bh=n0o3am6RbHP0WYBjb36BGqg94WCLacXxFKP26WZdJlc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Z5X+KOd0lqxjeZOMsPjCiKn0j0TtWFcT/QO3qhcLM+sRuyEkA2bR7gR0qxYmwubAy N3iBP0JBAZcef96MU9HwDsqm8pA5/JboSxleLl23BWtSIe7dAQQ8cn0pQrq4yqjCaW wCzGzcrX/u7z6gpjq5gSqaPxaHUTyrKSNSXT+kSA= Received: by simark.ca (Postfix) id 37C491E08D; Tue, 09 Dec 2025 13:22:48 -0500 (EST) Message-ID: <526b07c7-b82d-4096-bb82-580e0d84c55a@simark.ca> Date: Tue, 9 Dec 2025 13:22:47 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Rewrite the "show environment" test To: Tom Tromey , gdb-patches@sourceware.org References: <20251209180230.432182-1-tromey@adacore.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20251209180230.432182-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/9/25 1:02 PM, Tom Tromey wrote: > In a review early in the year: > > https://inbox.sourceware.org/gdb-patches/874iz3f4ek.fsf@redhat.com/ > > Andrew pointed out that a new test I proposed failed with read1. > This test was essentially a copy of gdb.base/environ.exp. > > I couldn't reproduce the read1 problem, but this patch rewrites the > one test there that seems like it could possibly fail in this mode. > Now it uses line-by-line mode and checks for a certain environment > variable appearing in the output. Seems fine to me. Approved-By: Simon Marchi Simon