From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix REGISTRY cleanups
Date: Mon, 28 Oct 2013 14:13:00 -0000 [thread overview]
Message-ID: <526E7107.8020706@redhat.com> (raw)
In-Reply-To: <526E599D.8020902@codesourcery.com>
On 10/28/2013 12:33 PM, Yao Qi wrote:
> On 10/28/2013 07:36 PM, Pedro Alves wrote:
>> (Yao, FYI, "fix" in the subject line confused me a little,
>> as I found myself scratching my head a little trying to understand
>> what bug this actually fixes, only to realize it's a code
>> cleanup sort of fix. I'd suggest changing the subject/commit
>> to reflect that.)
>
> How about "Simplify REGISTRY cleanup usages"? I also update the
> comments in registry.h to document the arguments of FREE function.
Looks good to me.
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2013-10-28 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 3:50 Yao Qi
2013-10-28 3:45 ` Joel Brobecker
2013-10-28 11:36 ` Pedro Alves
2013-10-28 12:35 ` Yao Qi
2013-10-28 14:13 ` Pedro Alves [this message]
2013-10-29 6:42 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E7107.8020706@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox