From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4723 invoked by alias); 28 Oct 2013 14:13:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4708 invoked by uid 89); 28 Oct 2013 14:13:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2013 14:13:34 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9SEDTq5011490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Oct 2013 10:13:29 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9SEDRHM009932; Mon, 28 Oct 2013 10:13:28 -0400 Message-ID: <526E7107.8020706@redhat.com> Date: Mon, 28 Oct 2013 14:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix REGISTRY cleanups References: <1382759328-23938-1-git-send-email-yao@codesourcery.com> <20131028034520.GB3066@adacore.com> <526E4C32.7080601@redhat.com> <526E599D.8020902@codesourcery.com> In-Reply-To: <526E599D.8020902@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00857.txt.bz2 On 10/28/2013 12:33 PM, Yao Qi wrote: > On 10/28/2013 07:36 PM, Pedro Alves wrote: >> (Yao, FYI, "fix" in the subject line confused me a little, >> as I found myself scratching my head a little trying to understand >> what bug this actually fixes, only to realize it's a code >> cleanup sort of fix. I'd suggest changing the subject/commit >> to reflect that.) > > How about "Simplify REGISTRY cleanup usages"? I also update the > comments in registry.h to document the arguments of FREE function. Looks good to me. Thanks, -- Pedro Alves