From: Yao Qi <yao@codesourcery.com>
To: Omair Javaid <omair.javaid@linaro.org>
Cc: <gdb-patches@sourceware.org>, Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH 2/2] GDB process record and reverse debugging improvements for arm*-linux*
Date: Thu, 24 Oct 2013 02:32:00 -0000 [thread overview]
Message-ID: <5268865F.6060307@codesourcery.com> (raw)
In-Reply-To: <CANW4E-0qP8iMVh1czWuOjhwfH9Q-2aJUG=2wEzDX1mLXy3avAw@mail.gmail.com>
On 10/24/2013 08:09 AM, Omair Javaid wrote:
> +/* Record all registers but PC register for process-record. */
> +
> +static int
> +arm_all_but_pc_registers_record (struct regcache *regcache)
> +{
> + if (record_full_arch_list_add_reg (regcache, ARM_R0_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R1_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R2_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R3_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R4_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R5_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R6_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R7_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R8_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R9_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R10_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R11_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R12_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R13_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_R14_REGNUM))
> + return -1;
> + if (record_full_arch_list_add_reg (regcache, ARM_PS_REGNUM))
> + return -1;
> +
> + return 0;
> +}
> +
Can't we use loop?
>
> /* Provide a prototype to silence -Wmissing-prototypes. */
> Index: gdb/arm-tdep.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/arm-tdep.h,v
> retrieving revision 1.59
> diff -u -p -r1.59 arm-tdep.h
> --- gdb/arm-tdep.h 19 Apr 2013 15:09:45 -0000 1.59
> +++ gdb/arm-tdep.h 23 Oct 2013 23:10:11 -0000
> @@ -60,7 +60,24 @@ enum gdb_regnum {
> ARM_NUM_ARG_REGS = 4,
> ARM_LAST_ARG_REGNUM = ARM_A4_REGNUM,
> ARM_NUM_FP_ARG_REGS = 4,
> - ARM_LAST_FP_ARG_REGNUM = ARM_F3_REGNUM
> + ARM_LAST_FP_ARG_REGNUM = ARM_F3_REGNUM,
> +
> + /* GPRs register numbers in sequence. */
> + ARM_R0_REGNUM = ARM_A1_REGNUM,
> + ARM_R1_REGNUM = ARM_R0_REGNUM + 1,
> + ARM_R2_REGNUM = ARM_R1_REGNUM + 1,
> + ARM_R3_REGNUM = ARM_R2_REGNUM + 1,
> + ARM_R4_REGNUM = ARM_R3_REGNUM + 1,
> + ARM_R5_REGNUM = ARM_R4_REGNUM + 1,
> + ARM_R6_REGNUM = ARM_R5_REGNUM + 1,
> + ARM_R7_REGNUM = ARM_R6_REGNUM + 1,
> + ARM_R8_REGNUM = ARM_R7_REGNUM + 1,
> + ARM_R9_REGNUM = ARM_R8_REGNUM + 1,
> + ARM_R10_REGNUM = ARM_R9_REGNUM + 1,
> + ARM_R11_REGNUM = ARM_R10_REGNUM + 1,
> + ARM_R12_REGNUM = ARM_R11_REGNUM + 1,
> + ARM_R13_REGNUM = ARM_R12_REGNUM + 1,
> + ARM_R14_REGNUM = ARM_R13_REGNUM + 1
> };
... then these macro are not needed.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-10-24 2:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 0:09 Omair Javaid
2013-10-24 2:32 ` Yao Qi [this message]
2013-11-08 5:32 ` Omair Javaid
2013-11-11 10:01 ` Yao Qi
2013-11-11 10:08 ` oza Pawandeep
[not found] ` <CANW4E-08KZaKZHXqKyw+T8KdrFAU8Z2UeAiQMej2LqdCVYu8oA@mail.gmail.com>
2013-11-24 23:48 ` Omair Javaid
2013-12-17 10:23 ` Omair Javaid
2013-12-20 12:37 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5268865F.6060307@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=omair.javaid@linaro.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox