From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29061 invoked by alias); 24 Oct 2013 02:32:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29050 invoked by uid 89); 24 Oct 2013 02:32:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Oct 2013 02:32:27 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VZAil-0000oB-OT from Yao_Qi@mentor.com ; Wed, 23 Oct 2013 19:32:23 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 23 Oct 2013 19:32:23 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Wed, 23 Oct 2013 19:32:22 -0700 Message-ID: <5268865F.6060307@codesourcery.com> Date: Thu, 24 Oct 2013 02:32:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Omair Javaid CC: , Patch Tracking Subject: Re: [PATCH 2/2] GDB process record and reverse debugging improvements for arm*-linux* References: In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00745.txt.bz2 On 10/24/2013 08:09 AM, Omair Javaid wrote: > +/* Record all registers but PC register for process-record. */ > + > +static int > +arm_all_but_pc_registers_record (struct regcache *regcache) > +{ > + if (record_full_arch_list_add_reg (regcache, ARM_R0_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R1_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R2_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R3_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R4_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R5_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R6_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R7_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R8_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R9_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R10_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R11_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R12_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R13_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_R14_REGNUM)) > + return -1; > + if (record_full_arch_list_add_reg (regcache, ARM_PS_REGNUM)) > + return -1; > + > + return 0; > +} > + Can't we use loop? > > /* Provide a prototype to silence -Wmissing-prototypes. */ > Index: gdb/arm-tdep.h > =================================================================== > RCS file: /cvs/src/src/gdb/arm-tdep.h,v > retrieving revision 1.59 > diff -u -p -r1.59 arm-tdep.h > --- gdb/arm-tdep.h 19 Apr 2013 15:09:45 -0000 1.59 > +++ gdb/arm-tdep.h 23 Oct 2013 23:10:11 -0000 > @@ -60,7 +60,24 @@ enum gdb_regnum { > ARM_NUM_ARG_REGS = 4, > ARM_LAST_ARG_REGNUM = ARM_A4_REGNUM, > ARM_NUM_FP_ARG_REGS = 4, > - ARM_LAST_FP_ARG_REGNUM = ARM_F3_REGNUM > + ARM_LAST_FP_ARG_REGNUM = ARM_F3_REGNUM, > + > + /* GPRs register numbers in sequence. */ > + ARM_R0_REGNUM = ARM_A1_REGNUM, > + ARM_R1_REGNUM = ARM_R0_REGNUM + 1, > + ARM_R2_REGNUM = ARM_R1_REGNUM + 1, > + ARM_R3_REGNUM = ARM_R2_REGNUM + 1, > + ARM_R4_REGNUM = ARM_R3_REGNUM + 1, > + ARM_R5_REGNUM = ARM_R4_REGNUM + 1, > + ARM_R6_REGNUM = ARM_R5_REGNUM + 1, > + ARM_R7_REGNUM = ARM_R6_REGNUM + 1, > + ARM_R8_REGNUM = ARM_R7_REGNUM + 1, > + ARM_R9_REGNUM = ARM_R8_REGNUM + 1, > + ARM_R10_REGNUM = ARM_R9_REGNUM + 1, > + ARM_R11_REGNUM = ARM_R10_REGNUM + 1, > + ARM_R12_REGNUM = ARM_R11_REGNUM + 1, > + ARM_R13_REGNUM = ARM_R12_REGNUM + 1, > + ARM_R14_REGNUM = ARM_R13_REGNUM + 1 > }; ... then these macro are not needed. -- Yao (齐尧)