Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] Fix typo in gdb/testsuite/gdb.arch/thumb2-it.S
@ 2013-10-20 13:55 Tom de Vries
  2013-10-21 14:51 ` Pedro Alves
  0 siblings, 1 reply; 5+ messages in thread
From: Tom de Vries @ 2013-10-20 13:55 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

Hi,

This patch fixes a typo in gdb/testsuite/gdb.arch/thumb2-it.S.

OK for trunk?

Thanks,
- Tom

2013-10-20  Tom de Vries  <tom@codesourcery.com>

	* gdb.arch/thumb2-it.S (it_8): Fix typo.

[-- Attachment #2: thumb2-it-typo.patch --]
[-- Type: text/x-patch, Size: 385 bytes --]

diff --git a/gdb/testsuite/gdb.arch/thumb2-it.S b/gdb/testsuite/gdb.arch/thumb2-it.S
index 3ba791d..425bc08 100644
--- a/gdb/testsuite/gdb.arch/thumb2-it.S
+++ b/gdb/testsuite/gdb.arch/thumb2-it.S
@@ -124,7 +124,7 @@ it_7:
 	bx	lr	@ Done, Check $r0 == 15
 
 	@ Block of four, only first executed.
-	.type it_3,%function
+	.type it_8,%function
 	.thumb_func
 it_8:
 	mov	r0, #0	@ Setup

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix typo in gdb/testsuite/gdb.arch/thumb2-it.S
  2013-10-20 13:55 [PATCH] Fix typo in gdb/testsuite/gdb.arch/thumb2-it.S Tom de Vries
@ 2013-10-21 14:51 ` Pedro Alves
  2013-10-21 15:25   ` Tom de Vries
  0 siblings, 1 reply; 5+ messages in thread
From: Pedro Alves @ 2013-10-21 14:51 UTC (permalink / raw)
  To: Tom de Vries; +Cc: gdb-patches

On 10/20/2013 02:55 PM, Tom de Vries wrote:

> 2013-10-20  Tom de Vries  <tom@codesourcery.com>
> 
> 	* gdb.arch/thumb2-it.S (it_8): Fix typo.

OK.

Thanks,
-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix typo in gdb/testsuite/gdb.arch/thumb2-it.S
  2013-10-21 14:51 ` Pedro Alves
@ 2013-10-21 15:25   ` Tom de Vries
  2013-10-21 15:33     ` Andreas Schwab
  2013-10-21 15:37     ` Sergio Durigan Junior
  0 siblings, 2 replies; 5+ messages in thread
From: Tom de Vries @ 2013-10-21 15:25 UTC (permalink / raw)
  To: Pedro Alves; +Cc: gdb-patches

On 21/10/13 16:51, Pedro Alves wrote:
> On 10/20/2013 02:55 PM, Tom de Vries wrote:
> 
>> 2013-10-20  Tom de Vries  <tom@codesourcery.com>
>>
>> 	* gdb.arch/thumb2-it.S (it_8): Fix typo.
> 
> OK.
> 

Pedro,

Thanks. I've tried to commit using cvs and got:
...
$ cvs commit -F ./thumb2-it-typo.log gdb/testsuite
...
binutils and gdb have migrated to git
cvs commit: Pre-commit check failed
binutils and gdb have migrated to git
cvs commit: Pre-commit check failed
cvs [commit aborted]: correct above errors first!
...

I suspect cvs is the way to apply since http://www.sourceware.org/gdb/current
says git is read-only. I suppose this error is due to lack of permissions.

I'd be happy to have checkin permissions, and to apply myself.

Otherwise, can you apply?

Thanks,
- Tom



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix typo in gdb/testsuite/gdb.arch/thumb2-it.S
  2013-10-21 15:25   ` Tom de Vries
@ 2013-10-21 15:33     ` Andreas Schwab
  2013-10-21 15:37     ` Sergio Durigan Junior
  1 sibling, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2013-10-21 15:33 UTC (permalink / raw)
  To: Tom de Vries; +Cc: Pedro Alves, gdb-patches

Tom de Vries <Tom_deVries@mentor.com> writes:

> I suspect cvs is the way to apply since http://www.sourceware.org/gdb/current
> says git is read-only. I suppose this error is due to lack of permissions.

See <http://permalink.gmane.org/gmane.comp.gnu.binutils/63624>.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix typo in gdb/testsuite/gdb.arch/thumb2-it.S
  2013-10-21 15:25   ` Tom de Vries
  2013-10-21 15:33     ` Andreas Schwab
@ 2013-10-21 15:37     ` Sergio Durigan Junior
  1 sibling, 0 replies; 5+ messages in thread
From: Sergio Durigan Junior @ 2013-10-21 15:37 UTC (permalink / raw)
  To: Tom de Vries; +Cc: Pedro Alves, gdb-patches

On Monday, October 21 2013, Tom de Vries wrote:

> On 21/10/13 16:51, Pedro Alves wrote:
>> On 10/20/2013 02:55 PM, Tom de Vries wrote:
>> 
>>> 2013-10-20  Tom de Vries  <tom@codesourcery.com>
>>>
>>> 	* gdb.arch/thumb2-it.S (it_8): Fix typo.
>> 
>> OK.
>> 
>
> Pedro,
>
> Thanks. I've tried to commit using cvs and got:
> ...
> $ cvs commit -F ./thumb2-it-typo.log gdb/testsuite
> ...
> binutils and gdb have migrated to git
> cvs commit: Pre-commit check failed
> binutils and gdb have migrated to git
> cvs commit: Pre-commit check failed
> cvs [commit aborted]: correct above errors first!
> ...
>
> I suspect cvs is the way to apply since http://www.sourceware.org/gdb/current
> says git is read-only. I suppose this error is due to lack of permissions.
>
> I'd be happy to have checkin permissions, and to apply myself.
>
> Otherwise, can you apply?

The GDB and binutils repositories (a.k.a. CVS "src" repo) is being
migrated to git right now.

         https://sourceware.org/ml/gdb/2013-10/msg00068.html

The commit has been disabled until the migration finishes.

-- 
Sergio


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-10-21 15:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-20 13:55 [PATCH] Fix typo in gdb/testsuite/gdb.arch/thumb2-it.S Tom de Vries
2013-10-21 14:51 ` Pedro Alves
2013-10-21 15:25   ` Tom de Vries
2013-10-21 15:33     ` Andreas Schwab
2013-10-21 15:37     ` Sergio Durigan Junior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox