Re: [PATCH] hardware watchpoints turned off, inferior not yet started

["Andrew Burgess" <aburgess@broadcom.com>]

On 18/10/2013 4:25 PM, Pedro Alves wrote:
> On 10/18/2013 10:14 AM, Andrew Burgess wrote:
>> After my patch then we do indeed see the error earlier, when the second
>> "file foo" is issued.
> 
> BTW, not super important, but thinking out loud, I think it'd
> make sense to have the "set can-use-hw-watchpoints" command
> itself trigger a breakpoint/watchpoint reset.

I initially planned to do just this, but the manual says that after
a "set can-use-hw-breakpoints 0" previous breakpoints will remain
hardware while future ones will be software.

This clearly breaks a little (depending on interpretation) with
restarting the inferior / changing the file but we'd either need
to update the manual or carry additional information around on the
watchpoint to indicate if it's supposed to be HW/SW.

Thanks for taking the time to review my patch :)

Andrew