Re: C++-compat clean build

[Pedro Alves <palves@redhat.com>]

On 10/01/2013 01:53 PM, Jan Kratochvil wrote:
> Hi Ondrej,
> 
> On Tue, 01 Oct 2013 13:25:34 +0200, Ondrej Oprala wrote:
>> this is the first of a few patches I intend to write to make gdb
>> code compile cleanly with -Wc++-compat.
>> The idea is to make separate patches for respective subdirs under
>> gdb/, unless someone objects ofc.
> 
> this is a too huge patch.  It should import first archer/tromey/c++ which is
> already separated into specific parts, that is each commit in that branch
> should be a separate posted mail/patch.  This could also state the gcc error
> that occured, it is not always clear for review (such as the ptrace case).
> 
> According to gdb/CONTRIBUTE there should be written ChangeLog entries, that is
> what will be written to gdb/ChangeLog (one writes them as plain text into the
> mail, not directly patching the file gdb/ChangeLog, as the ChangeLog patch
> would get immediately out of scope).  Some requests for comments without
> immediate check-in may got without ChangeLog entry, such as this preview
> patch.

See also <https://sourceware.org/gdb/wiki/ContributionChecklist>,
which talks about that and more.

> 
> It is not a requirement but the preference is to post the patches inlined in
> the mail text; just I am not sure Thunderbird will not corrupt it, your mail
> body is format=flowed which would corrupt it, OTOH without format=flowed some
> mailers wrap the patch to some fixed column.  So maybe the attachment is the
> least worst for Thunderbird.

At <https://sourceware.org/gdb/wiki/ContributionChecklist#Submitting_patches>
you'll find a link to mozilla's own knowledge base explaining how to configure
Thunderbird for sending patches.

-- 
Pedro Alves