From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: ooprala@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: C++-compat clean build
Date: Tue, 01 Oct 2013 12:04:00 -0000 [thread overview]
Message-ID: <201310011204.r91C4QVo006124@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <524AB12E.8090209@redhat.com> (message from Ondrej Oprala on Tue, 01 Oct 2013 13:25:34 +0200)
> Date: Tue, 01 Oct 2013 13:25:34 +0200
> From: Ondrej Oprala <ooprala@redhat.com>
>
> Hi,
> this is the first of a few patches I intend to write to make gdb code
> compile cleanly with -Wc++-compat.
> The idea is to make separate patches for respective subdirs under gdb/,
> unless someone objects ofc.
>
> Thanks in advance for any advice/criticism.
Rejected. Introducing all these casts can't be right. They hide type
conversion issues and make the code unreadable.
next prev parent reply other threads:[~2013-10-01 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 11:25 Ondrej Oprala
2013-10-01 11:52 ` Ondrej Oprala
2013-10-01 12:04 ` Mark Kettenis [this message]
2013-10-01 12:53 ` Agovic, Sanimir
2013-10-01 14:16 ` Pedro Alves
2013-10-01 16:34 ` Joel Brobecker
2013-10-01 12:53 ` Jan Kratochvil
2013-10-01 12:57 ` Ondrej Oprala
2013-10-01 13:06 ` Tedeschi, Walfred
2013-10-01 13:57 ` Pedro Alves
2013-10-03 20:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310011204.r91C4QVo006124@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=ooprala@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox