Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <lgustavo@codesourcery.com>
Cc: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>,
	 Pedro Alves <palves@redhat.com>,
	Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH, cleanup] Standardize access to ptid
Date: Wed, 25 Sep 2013 00:51:00 -0000	[thread overview]
Message-ID: <5242336C.20608@codesourcery.com> (raw)
In-Reply-To: <523B7A79.1060901@codesourcery.com>

Ping?

Hopefully this patch is not too gross.

On 09/19/2013 07:28 PM, Luis Machado wrote:
> Hi,
>
> This is what i came up with in response to the presence of a number of
> macros to access ptid members and to do ptid-related checks.
>
> I've dropped all the macros and used the underlying implementation where
> suitable. New functions were created (ptid_is_lwp, ptid_is_tid) to do
> additional checks without the need of macros.
>
> I've grouped the null_ptid and minus_one_ptid checks inside
> ptid_is_invalid to reuse existing code.
>
> A run from the testsuite tells me there are no regressions.
>
> I've been extra careful to convert from the ptid-building macros to the
> ptid_build function since sol-thread.c and aix-thread.c had some
> variations regarding the position of TID/LWP inside the ptid. Please
> double check.
>
> Luis


  reply	other threads:[~2013-09-25  0:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 22:28 Luis Machado
2013-09-25  0:51 ` Luis Machado [this message]
2013-09-26 12:53 ` Joel Brobecker
2013-09-26 12:58   ` Luis Machado
2013-09-26 15:10     ` Pedro Alves
2013-09-29 17:17       ` Luis Machado
2013-09-29 18:45         ` Pedro Alves
2013-09-30 11:50           ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5242336C.20608@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox