From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16879 invoked by alias); 25 Sep 2013 00:51:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16699 invoked by uid 89); 25 Sep 2013 00:51:18 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Sep 2013 00:51:18 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,MISSING_HEADERS,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VOdJx-0003n3-GT from Luis_Gustavo@mentor.com ; Tue, 24 Sep 2013 17:51:13 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 24 Sep 2013 17:51:13 -0700 Received: from [172.30.4.181] ([172.30.4.181]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 24 Sep 2013 17:51:12 -0700 Message-ID: <5242336C.20608@codesourcery.com> Date: Wed, 25 Sep 2013 00:51:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 CC: "'gdb-patches@sourceware.org'" , Pedro Alves , Joel Brobecker Subject: Re: [PATCH, cleanup] Standardize access to ptid References: <523B7A79.1060901@codesourcery.com> In-Reply-To: <523B7A79.1060901@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00886.txt.bz2 Ping? Hopefully this patch is not too gross. On 09/19/2013 07:28 PM, Luis Machado wrote: > Hi, > > This is what i came up with in response to the presence of a number of > macros to access ptid members and to do ptid-related checks. > > I've dropped all the macros and used the underlying implementation where > suitable. New functions were created (ptid_is_lwp, ptid_is_tid) to do > additional checks without the need of macros. > > I've grouped the null_ptid and minus_one_ptid checks inside > ptid_is_invalid to reuse existing code. > > A run from the testsuite tells me there are no regressions. > > I've been extra careful to convert from the ptid-building macros to the > ptid_build function since sol-thread.c and aix-thread.c had some > variations regarding the position of TID/LWP inside the ptid. Please > double check. > > Luis