From: Simon Marchi <simon.marchi@polymtl.ca>
To: Christian Biesinger <cbiesinger@google.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb, gdbserver, gdbsupport: fix leading space vs tabs issues
Date: Mon, 14 Sep 2020 13:06:15 -0400 [thread overview]
Message-ID: <523c6bab-52bf-c19c-9810-ae32f258a747@polymtl.ca> (raw)
In-Reply-To: <CAPTJ0XHrvRy_B8_qAcY-M3iJYiZaCY9PUS6zvQrAY885hybwzQ@mail.gmail.com>
On 2020-09-14 12:25 p.m., Christian Biesinger wrote:
> On Mon, Sep 14, 2020 at 6:13 PM Simon Marchi via Gdb-patches
> <gdb-patches@sourceware.org> wrote:
>>
>> Many spots incorrectly use only spaces for indentation (for example,
>> there are a lot of spots in ada-lang.c). I've always found it awkward
>> when I needed to edit one of these spots: do I keep the original wrong
>> indentation, or do I fix it? What if the lines around it are also
>> wrong, do I fix them too? I probably don't want to fix them in the same
>> patch, to avoid adding noise to my patch.
>>
>> So I propose to fix as much as possible once and for all (hopefully).
>>
>> One typical counter argument for this is that it makes code archeology
>> more difficult, because git-blame will show this commit as the last
>> change for these lines.
>
> For what it's worth, git blame offers a -w switch to ignore whitespace changes.
>
> Christian
>
I didn't know that, that's even better!
Simon
next prev parent reply other threads:[~2020-09-14 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 16:13 Simon Marchi
2020-09-14 16:25 ` Christian Biesinger
2020-09-14 17:06 ` Simon Marchi [this message]
2020-10-26 16:29 ` Simon Marchi
2020-11-02 15:30 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523c6bab-52bf-c19c-9810-ae32f258a747@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox