From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 972593857836 for ; Mon, 14 Sep 2020 17:06:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 972593857836 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 08EH6GIC016892 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Sep 2020 13:06:21 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 08EH6GIC016892 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 729201E055; Mon, 14 Sep 2020 13:06:16 -0400 (EDT) Subject: Re: [PATCH] gdb, gdbserver, gdbsupport: fix leading space vs tabs issues To: Christian Biesinger Cc: "gdb-patches@sourceware.org" References: <7174ea3f-ea3d-dad9-ab63-df7586ae0f9e@polymtl.ca> From: Simon Marchi Message-ID: <523c6bab-52bf-c19c-9810-ae32f258a747@polymtl.ca> Date: Mon, 14 Sep 2020 13:06:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 14 Sep 2020 17:06:16 +0000 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-DCC: debian: antispam2020.polymtl.ca 1169; Body=1 Fuz1=1 Fuz2=1 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2020 17:06:26 -0000 On 2020-09-14 12:25 p.m., Christian Biesinger wrote: > On Mon, Sep 14, 2020 at 6:13 PM Simon Marchi via Gdb-patches > wrote: >> >> Many spots incorrectly use only spaces for indentation (for example, >> there are a lot of spots in ada-lang.c). I've always found it awkward >> when I needed to edit one of these spots: do I keep the original wrong >> indentation, or do I fix it? What if the lines around it are also >> wrong, do I fix them too? I probably don't want to fix them in the same >> patch, to avoid adding noise to my patch. >> >> So I propose to fix as much as possible once and for all (hopefully). >> >> One typical counter argument for this is that it makes code archeology >> more difficult, because git-blame will show this commit as the last >> change for these lines. > > For what it's worth, git blame offers a -w switch to ignore whitespace changes. > > Christian > I didn't know that, that's even better! Simon