Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Doug Evans <dje@sceeck.org>
Cc: gdb-patches@sourceware.org
Subject: Re: beginnings of Guile support
Date: Fri, 06 Sep 2013 16:27:00 -0000	[thread overview]
Message-ID: <522A0287.40700@redhat.com> (raw)
In-Reply-To: <CAEei7h90tuXtBzVbNjtLQkv6ECA+EsdkYmt==MEMJcUf3m-bcA@mail.gmail.com>

On 06/09/13 16:35, Doug Evans wrote:
> Hi.
> As a personal project, I'm adding scheme scripting to gdb.
> This patch is very preliminary (no docs, etc. etc. etc.), but I want
> to give people a heads up.
> 
> To try to plug scheme in cleanly I've created scripting.[ch] as the
> interface between gdb and python/scheme.  It's not complete, not least
> of which is varobj.c, but it feels reasonable.


Nice work, Doug.  In particular the architectural changes to move the
scripting language infrastructure support to a more generic naming,
and agnostic point of view.  (I guess we should have thought about
this way back when).

The only comments I have are the conflicts when dealing with areas
where an internal GDB, a Python, Guile, and some other future language
conflict might occur.  I noticed you removed the conditional
breakpoint check where only a Python "stop" callback can be attached
to a breakpoint, or a "traditional" GDB condition.  Your work is a
work in progress, so I am not going to worry too much at the moment.
But every "stop" callback attached to a breakpoint must be allowed to
run, even if the a previous "stop" callback indicated True to stop, or
a previous condition expression attached to GDB resolved to True.  I
guess we can look at this area again when your work is getting closer
to submission.

Thanks for the preview.  Are you aiming for 100% feature parity with
the Python work? (IE, frame filters, etc)

Cheers,

Phil


  reply	other threads:[~2013-09-06 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 15:35 Doug Evans
2013-09-06 16:27 ` Phil Muldoon [this message]
2013-09-10  5:20   ` Doug Evans
2013-09-09 21:09 ` Tom Tromey
2013-09-10  5:21   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522A0287.40700@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=dje@sceeck.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox