From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24672 invoked by alias); 6 Sep 2013 16:27:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24660 invoked by uid 89); 6 Sep 2013 16:27:57 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 16:27:57 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r86GRsia023760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Sep 2013 12:27:54 -0400 Received: from localhost.localdomain (ovpn-112-30.ams2.redhat.com [10.36.112.30]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r86GRqcx023079; Fri, 6 Sep 2013 12:27:53 -0400 Message-ID: <522A0287.40700@redhat.com> Date: Fri, 06 Sep 2013 16:27:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Doug Evans CC: gdb-patches@sourceware.org Subject: Re: beginnings of Guile support References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00243.txt.bz2 On 06/09/13 16:35, Doug Evans wrote: > Hi. > As a personal project, I'm adding scheme scripting to gdb. > This patch is very preliminary (no docs, etc. etc. etc.), but I want > to give people a heads up. > > To try to plug scheme in cleanly I've created scripting.[ch] as the > interface between gdb and python/scheme. It's not complete, not least > of which is varobj.c, but it feels reasonable. Nice work, Doug. In particular the architectural changes to move the scripting language infrastructure support to a more generic naming, and agnostic point of view. (I guess we should have thought about this way back when). The only comments I have are the conflicts when dealing with areas where an internal GDB, a Python, Guile, and some other future language conflict might occur. I noticed you removed the conditional breakpoint check where only a Python "stop" callback can be attached to a breakpoint, or a "traditional" GDB condition. Your work is a work in progress, so I am not going to worry too much at the moment. But every "stop" callback attached to a breakpoint must be allowed to run, even if the a previous "stop" callback indicated True to stop, or a previous condition expression attached to GDB resolved to True. I guess we can look at this area again when your work is getting closer to submission. Thanks for the preview. Are you aiming for 100% feature parity with the Python work? (IE, frame filters, etc) Cheers, Phil